From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13997 invoked by alias); 22 Nov 2008 16:39:29 -0000 Received: (qmail 13984 invoked by uid 22791); 22 Nov 2008 16:39:28 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 22 Nov 2008 16:38:53 +0000 Received: (qmail 31874 invoked from network); 22 Nov 2008 16:38:51 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 22 Nov 2008 16:38:51 -0000 From: Vladimir Prus To: Daniel Jacobowitz Subject: Re: [RFA] -list-target-groups --available Date: Sun, 23 Nov 2008 02:14:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sources.redhat.com References: <200811142003.33600.vladimir@codesourcery.com> <20081120144226.GA9855@caradoc.them.org> In-Reply-To: <20081120144226.GA9855@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811221938.51061.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00609.txt.bz2 On Thursday 20 November 2008 17:42:26 Daniel Jacobowitz wrote: > On Fri, Nov 14, 2008 at 08:03:33PM +0300, Vladimir Prus wrote: > > > > This patch implements MI '-list-target-groups --available' -- for > > native linux and remote targets. In both cases, the command actually > > returns the list of processes. The bulk of the patch was written by > > Pedro, I've just added MI bits to it. > > All the code looks OK to me. However, I would not like to add this > patch without testcases or documentation. There should be a DTD > somewhere, too. This version has DTD. It also has documentation -- Eli, can you review it. I did you found a good place where new "info os processes" should be documented, any suggestions? I've also added a minimal test for the new functionality -- it basically makes sure we can get some process list, when using gdbserver on linux. Given that it's very system-dependent, I don't think we can do better. > > > +void > > +_initialize_osdata (void) > > +{ > > + add_info ("os", info_osdata_command, > > + _("Show OS data ARG.")); > > + > > + /* An alias for "info osdata processes". */ > > + add_info ("processes", info_processes_command, > > + _("List running processes on the target.")); > > +} > > "info os processes" or "info osdata"? I wonder if the alias should be dropped -- "info processes" can be easily confused with "info inferiors". - Volodya