From: dje@google.com (Doug Evans)
To: gdb-patches@sourceware.org
Subject: [ob] remove proceed_to_finish from inferior.h
Date: Thu, 20 Nov 2008 02:15:00 -0000 [thread overview]
Message-ID: <20081120003536.CEC4B1C799D@localhost> (raw)
Hi. proceed_to_finish in inferior.h got left behind when it
was moved to gdbthread.h.
I also tweaked a comment on stop_registers so it's clearer.
Checked in as obvious.
2008-11-19 Doug Evans <dje@google.com>
* inferior.h (proceed_to_finish): Delete, unused.
(stop_registers): Tweak comment.
* infrun.c (stop_registers): Tweak comment.
Index: inferior.h
===================================================================
RCS file: /cvs/src/src/gdb/inferior.h,v
retrieving revision 1.115
diff -u -p -r1.115 inferior.h
--- inferior.h 17 Nov 2008 16:37:34 -0000 1.115
+++ inferior.h 20 Nov 2008 00:28:40 -0000
@@ -342,13 +342,8 @@ enum exec_direction_kind
extern enum exec_direction_kind execution_direction;
-/* Nonzero if proceed is being used for a "finish" command or a similar
- situation when stop_registers should be saved. */
-
-extern int proceed_to_finish;
-
-/* Save register contents here when about to pop a stack dummy frame,
- if-and-only-if proceed_to_finish is set.
+/* Save register contents here when executing a "finish" command or are
+ about to pop a stack dummy frame, if-and-only-if proceed_to_finish is set.
Thus this contains the return value from the called function (assuming
values are returned in a register). */
Index: infrun.c
===================================================================
RCS file: /cvs/src/src/gdb/infrun.c,v
retrieving revision 1.338
diff -u -p -r1.338 infrun.c
--- infrun.c 17 Nov 2008 18:50:22 -0000 1.338
+++ infrun.c 20 Nov 2008 00:28:40 -0000
@@ -232,8 +232,8 @@ show_stop_on_solib_events (struct ui_fil
int stop_after_trap;
-/* Save register contents here when about to pop a stack dummy frame,
- if-and-only-if proceed_to_finish is set.
+/* Save register contents here when executing a "finish" command or are
+ about to pop a stack dummy frame, if-and-only-if proceed_to_finish is set.
Thus this contains the return value from the called function (assuming
values are returned in a register). */
reply other threads:[~2008-11-20 0:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081120003536.CEC4B1C799D@localhost \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox