From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10954 invoked by alias); 20 Nov 2008 00:36:16 -0000 Received: (qmail 10845 invoked by uid 22791); 20 Nov 2008 00:36:15 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 20 Nov 2008 00:35:40 +0000 Received: from zps78.corp.google.com (zps78.corp.google.com [172.25.146.78]) by smtp-out.google.com with ESMTP id mAK0Zcen020724 for ; Wed, 19 Nov 2008 16:35:38 -0800 Received: from localhost (ruffy.corp.google.com [172.18.118.116]) by zps78.corp.google.com with ESMTP id mAK0Zbpu014954 for ; Wed, 19 Nov 2008 16:35:37 -0800 Received: by localhost (Postfix, from userid 67641) id CEC4B1C799D; Wed, 19 Nov 2008 16:35:36 -0800 (PST) To: gdb-patches@sourceware.org Subject: [ob] remove proceed_to_finish from inferior.h Message-Id: <20081120003536.CEC4B1C799D@localhost> Date: Thu, 20 Nov 2008 02:15:00 -0000 From: dje@google.com (Doug Evans) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00518.txt.bz2 Hi. proceed_to_finish in inferior.h got left behind when it was moved to gdbthread.h. I also tweaked a comment on stop_registers so it's clearer. Checked in as obvious. 2008-11-19 Doug Evans * inferior.h (proceed_to_finish): Delete, unused. (stop_registers): Tweak comment. * infrun.c (stop_registers): Tweak comment. Index: inferior.h =================================================================== RCS file: /cvs/src/src/gdb/inferior.h,v retrieving revision 1.115 diff -u -p -r1.115 inferior.h --- inferior.h 17 Nov 2008 16:37:34 -0000 1.115 +++ inferior.h 20 Nov 2008 00:28:40 -0000 @@ -342,13 +342,8 @@ enum exec_direction_kind extern enum exec_direction_kind execution_direction; -/* Nonzero if proceed is being used for a "finish" command or a similar - situation when stop_registers should be saved. */ - -extern int proceed_to_finish; - -/* Save register contents here when about to pop a stack dummy frame, - if-and-only-if proceed_to_finish is set. +/* Save register contents here when executing a "finish" command or are + about to pop a stack dummy frame, if-and-only-if proceed_to_finish is set. Thus this contains the return value from the called function (assuming values are returned in a register). */ Index: infrun.c =================================================================== RCS file: /cvs/src/src/gdb/infrun.c,v retrieving revision 1.338 diff -u -p -r1.338 infrun.c --- infrun.c 17 Nov 2008 18:50:22 -0000 1.338 +++ infrun.c 20 Nov 2008 00:28:40 -0000 @@ -232,8 +232,8 @@ show_stop_on_solib_events (struct ui_fil int stop_after_trap; -/* Save register contents here when about to pop a stack dummy frame, - if-and-only-if proceed_to_finish is set. +/* Save register contents here when executing a "finish" command or are + about to pop a stack dummy frame, if-and-only-if proceed_to_finish is set. Thus this contains the return value from the called function (assuming values are returned in a register). */