From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] Fix thinko in frame_debug_got_null_frame
Date: Tue, 18 Nov 2008 18:54:00 -0000 [thread overview]
Message-ID: <20081118033425.GA18294@caradoc.them.org> (raw)
In-Reply-To: <20081118000011.4F9AB1C799B@localhost>
On Mon, Nov 17, 2008 at 04:00:11PM -0800, Doug Evans wrote:
> All uses of frame_debug in frame.c output to gdb_stdlog,
> so I don't see that there's any real point in having
> frame_debug_got_null_frame take a file arg.
>
> Still, maybe there's a reason for keeping the `file' arg.
>
> Which patch do you prefer? I like the first patch, deleting `file'.
>
> 2008-11-17 Doug Evans <dje@google.com>
>
> * frame.c (frame_debug_got_null_frame): Remove file arg.
> All callers updated.
This one's fine by me.
--
Daniel Jacobowitz
CodeSourcery
prev parent reply other threads:[~2008-11-18 3:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-18 17:13 Doug Evans
2008-11-18 18:54 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118033425.GA18294@caradoc.them.org \
--to=drow@false.org \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox