From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3881 invoked by alias); 18 Nov 2008 03:35:09 -0000 Received: (qmail 3820 invoked by uid 22791); 18 Nov 2008 03:35:08 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 18 Nov 2008 03:34:28 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 5282310DB0; Tue, 18 Nov 2008 03:34:26 +0000 (GMT) Received: from caradoc.them.org (209.195.188.212.nauticom.net [209.195.188.212]) by nan.false.org (Postfix) with ESMTP id 095D710D50; Tue, 18 Nov 2008 03:34:25 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1L2HM9-00050X-3S; Mon, 17 Nov 2008 22:34:25 -0500 Date: Tue, 18 Nov 2008 18:54:00 -0000 From: Daniel Jacobowitz To: Doug Evans Cc: gdb-patches@sourceware.org Subject: Re: [RFA] Fix thinko in frame_debug_got_null_frame Message-ID: <20081118033425.GA18294@caradoc.them.org> Mail-Followup-To: Doug Evans , gdb-patches@sourceware.org References: <20081118000011.4F9AB1C799B@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20081118000011.4F9AB1C799B@localhost> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00460.txt.bz2 On Mon, Nov 17, 2008 at 04:00:11PM -0800, Doug Evans wrote: > All uses of frame_debug in frame.c output to gdb_stdlog, > so I don't see that there's any real point in having > frame_debug_got_null_frame take a file arg. > > Still, maybe there's a reason for keeping the `file' arg. > > Which patch do you prefer? I like the first patch, deleting `file'. > > 2008-11-17 Doug Evans > > * frame.c (frame_debug_got_null_frame): Remove file arg. > All callers updated. This one's fine by me. -- Daniel Jacobowitz CodeSourcery