From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: pedro@codesourcery.com (Pedro Alves)
Cc: gdb-patches@sourceware.org, drow@false.org
Subject: Re: [rfc] Fix PR 2250 - multithreaded single-step problems in all-stop mode
Date: Mon, 17 Nov 2008 22:19:00 -0000 [thread overview]
Message-ID: <200811171856.mAHIuMHs011334@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200811151610.40427.pedro@codesourcery.com> from "Pedro Alves" at Nov 15, 2008 04:10:39 PM
Pedro Alves wrote:
> On Friday 14 November 2008 21:04:18, Ulrich Weigand wrote:
> > Does this look right? If there are no objections, I'm planning
> > on committing this in a couple of days.
>
> I like this a lot.
Thanks for looking over the patch!
I've checked this in now.
> Hmm, speaking of things that aren't cleared properly in all
> threads when we are going to start a proceed, shouldn't the
> things cleared in init_thread_stepping_state be cleared
> in clear_proceed_status_thread instead? E.g.,
> step_after_step_resume_breakpoint, etc.
Yes, it would appear everything except setting current_line
and current_symtab (which depend on prev_pc) should really
be cleared in clear_proceed_status_thread ... I'll come
up with an add-on patch.
B.t.w. what about init_execution_control_state? This seems to
be nowhere called ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2008-11-17 18:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-15 16:42 Ulrich Weigand
2008-11-15 21:30 ` Pedro Alves
2008-11-17 22:19 ` Ulrich Weigand [this message]
2008-11-17 23:36 ` Pedro Alves
2008-11-18 1:43 ` Ulrich Weigand
2008-11-18 3:36 ` Pedro Alves
2008-12-07 0:16 ` [rfc] [0/7] infrun cleanup Ulrich Weigand
2008-12-07 1:29 ` Pedro Alves
2008-12-07 17:12 ` Pedro Alves
2008-12-07 18:20 ` Ulrich Weigand
2008-12-07 19:16 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811171856.mAHIuMHs011334@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox