From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3961 invoked by alias); 17 Nov 2008 18:57:53 -0000 Received: (qmail 3891 invoked by uid 22791); 17 Nov 2008 18:57:52 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 17 Nov 2008 18:57:04 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id mAHIuNpD635920 for ; Mon, 17 Nov 2008 18:56:23 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id mAHIuNF94337710 for ; Mon, 17 Nov 2008 19:56:23 +0100 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id mAHIuMZF011337 for ; Mon, 17 Nov 2008 19:56:22 +0100 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id mAHIuMHs011334; Mon, 17 Nov 2008 19:56:22 +0100 Message-Id: <200811171856.mAHIuMHs011334@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Mon, 17 Nov 2008 19:56:22 +0100 Subject: Re: [rfc] Fix PR 2250 - multithreaded single-step problems in all-stop mode To: pedro@codesourcery.com (Pedro Alves) Date: Mon, 17 Nov 2008 22:19:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org, drow@false.org In-Reply-To: <200811151610.40427.pedro@codesourcery.com> from "Pedro Alves" at Nov 15, 2008 04:10:39 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00437.txt.bz2 Pedro Alves wrote: > On Friday 14 November 2008 21:04:18, Ulrich Weigand wrote: > > Does this look right? If there are no objections, I'm planning > > on committing this in a couple of days. > > I like this a lot. Thanks for looking over the patch! I've checked this in now. > Hmm, speaking of things that aren't cleared properly in all > threads when we are going to start a proceed, shouldn't the > things cleared in init_thread_stepping_state be cleared > in clear_proceed_status_thread instead? E.g., > step_after_step_resume_breakpoint, etc. Yes, it would appear everything except setting current_line and current_symtab (which depend on prev_pc) should really be cleared in clear_proceed_status_thread ... I'll come up with an add-on patch. B.t.w. what about init_execution_control_state? This seems to be nowhere called ... Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com