From: Joel Brobecker <brobecker@adacore.com>
To: Thiago Jung Bauermann <bauerman@BR.IBM.COM>
Cc: gdb-patches ml <gdb-patches@sourceware.org>
Subject: Re: [rfc][2/2] add suport for 64-bit fpscr in gdbserver for powerpc linux
Date: Fri, 14 Nov 2008 11:42:00 -0000 [thread overview]
Message-ID: <20081114002638.GB12484@adacore.com> (raw)
In-Reply-To: <1221436907.17278.6.camel@localhost.localdomain>
This one is in gdbserver, which I have very rarely touched, bug given
the age of your patch, I decided to take a look.
> 2008-09-14 Thiago Jung Bauermann <bauerman@br.ibm.com>
>
> gdb/
> * features/Makefile (rs6000/powerpc-isa205-32l-expedite,
> rs6000/powerpc-isa205-altivec32l-expedite,
> powerpc-isa205-vsx32l-expedite, rs6000/powerpc-isa205-64l-expedite,
> rs6000/powerpc-isa205-altivec64l-expedite,
> powerpc-isa205-vsx64l-expedite): New variables.
> * regformats/rs6000/powerpc-isa205-32l.dat: Generate.
> * regformats/rs6000/powerpc-isa205-altivec32l.dat: Generate.
> * regformats/rs6000/powerpc-isa205-vsx32l.dat: Generate.
> * regformats/rs6000/powerpc-isa205-64l.dat: Generate.
> * regformats/rs6000/powerpc-isa205-altivec64l.dat: Generate.
> * regformats/rs6000/powerpc-isa205-vsx64l.dat: Generate.
>
> gdbserver/
> * Makefile.in (powerpc-isa205-32l.o, powerpc-isa205-32l.c,
> powerpc-isa205-altivec32l.o, powerpc-isa205-altivec32l.c,
> powerpc-isa205-vsx32l.o, powerpc-isa205-vsx32l.c,
> powerpc-isa205-64l.o, powerpc-isa205-64l.c,
> powerpc-isa205-altivec64l.o, powerpc-isa205-altivec64l.c,
> powerpc-isa205-vsx64l.o, powerpc-isa205-vsx64l.c): New targets.
> * configure.srv (powerpc*-*-linux*): Add ISA 2.05 object files and
> XML target descriptions.
> * linux-ppc-low.c (ppc_arch_setup): Init registers with 64-bit FPSCR
> when inferior is running on an ISA 2.05 or later processor. Add
> special case to return offset for full 64-bit slot of FPSCR when
> in 32-bits.
Everything looks sane to me, and consistent with the rest of the code.
So give it a few more days, and commit at the same time you commit the
associated GDB part.
:REVIEWMAIL:
--
Joel
next prev parent reply other threads:[~2008-11-14 0:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 0:03 Thiago Jung Bauermann
2008-09-24 16:57 ` Thiago Jung Bauermann
2008-11-13 20:09 ` Thiago Jung Bauermann
2008-11-14 11:42 ` Joel Brobecker [this message]
2008-11-18 5:46 ` Thiago Jung Bauermann
2008-11-19 14:04 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081114002638.GB12484@adacore.com \
--to=brobecker@adacore.com \
--cc=bauerman@BR.IBM.COM \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox