From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18939 invoked by alias); 14 Nov 2008 00:27:50 -0000 Received: (qmail 18835 invoked by uid 22791); 14 Nov 2008 00:27:48 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 14 Nov 2008 00:26:42 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id D60CF1EE9A0; Thu, 13 Nov 2008 19:26:40 -0500 (EST) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id tk1Zx7gN1lVh; Thu, 13 Nov 2008 19:26:40 -0500 (EST) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 92D821EE99E; Thu, 13 Nov 2008 19:26:40 -0500 (EST) Received: by joel.gnat.com (Postfix, from userid 1000) id 64977E7ACD; Thu, 13 Nov 2008 16:26:38 -0800 (PST) Date: Fri, 14 Nov 2008 11:42:00 -0000 From: Joel Brobecker To: Thiago Jung Bauermann Cc: gdb-patches ml Subject: Re: [rfc][2/2] add suport for 64-bit fpscr in gdbserver for powerpc linux Message-ID: <20081114002638.GB12484@adacore.com> References: <1221436907.17278.6.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1221436907.17278.6.camel@localhost.localdomain> User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00316.txt.bz2 This one is in gdbserver, which I have very rarely touched, bug given the age of your patch, I decided to take a look. > 2008-09-14 Thiago Jung Bauermann > > gdb/ > * features/Makefile (rs6000/powerpc-isa205-32l-expedite, > rs6000/powerpc-isa205-altivec32l-expedite, > powerpc-isa205-vsx32l-expedite, rs6000/powerpc-isa205-64l-expedite, > rs6000/powerpc-isa205-altivec64l-expedite, > powerpc-isa205-vsx64l-expedite): New variables. > * regformats/rs6000/powerpc-isa205-32l.dat: Generate. > * regformats/rs6000/powerpc-isa205-altivec32l.dat: Generate. > * regformats/rs6000/powerpc-isa205-vsx32l.dat: Generate. > * regformats/rs6000/powerpc-isa205-64l.dat: Generate. > * regformats/rs6000/powerpc-isa205-altivec64l.dat: Generate. > * regformats/rs6000/powerpc-isa205-vsx64l.dat: Generate. > > gdbserver/ > * Makefile.in (powerpc-isa205-32l.o, powerpc-isa205-32l.c, > powerpc-isa205-altivec32l.o, powerpc-isa205-altivec32l.c, > powerpc-isa205-vsx32l.o, powerpc-isa205-vsx32l.c, > powerpc-isa205-64l.o, powerpc-isa205-64l.c, > powerpc-isa205-altivec64l.o, powerpc-isa205-altivec64l.c, > powerpc-isa205-vsx64l.o, powerpc-isa205-vsx64l.c): New targets. > * configure.srv (powerpc*-*-linux*): Add ISA 2.05 object files and > XML target descriptions. > * linux-ppc-low.c (ppc_arch_setup): Init registers with 64-bit FPSCR > when inferior is running on an ISA 2.05 or later processor. Add > special case to return offset for full 64-bit slot of FPSCR when > in 32-bits. Everything looks sane to me, and consistent with the rest of the code. So give it a few more days, and commit at the same time you commit the associated GDB part. :REVIEWMAIL: -- Joel