Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Vladimir Prus <vladimir@codesourcery.com>
To: Daniel Jacobowitz <drow@false.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Make attach_command exception-safe
Date: Mon, 03 Nov 2008 21:08:00 -0000	[thread overview]
Message-ID: <200811040008.05287.vladimir@codesourcery.com> (raw)
In-Reply-To: <20080829142418.GA15675@caradoc.them.org>

On Friday 29 August 2008 18:24:18 Daniel Jacobowitz wrote:
> On Fri, Aug 29, 2008 at 07:10:42AM +0000, Vladimir Prus wrote:
> > 
> > When attach_command executes, it might disable stdin. It further might
> > throw, and does not enable stdin in that case. For CLI case, top-level
> > event loop will catch the exception and enable stdin. For MI case, MI
> > interpreter catches the exception in order to print the error message,
> > and of course it has no idea about any stdin disabling.
> > 
> > This patch makes attach_command exception-safe, enabling stdin on
> > throw.
> > 
> > OK?
> 
> OK.

I've now checked this in.

Thanks,
Volodya


      reply	other threads:[~2008-11-03 21:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-29  7:11 Vladimir Prus
2008-08-29 15:23 ` Daniel Jacobowitz
2008-11-03 21:08   ` Vladimir Prus [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811040008.05287.vladimir@codesourcery.com \
    --to=vladimir@codesourcery.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox