From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23246 invoked by alias); 3 Nov 2008 21:08:55 -0000 Received: (qmail 23172 invoked by uid 22791); 3 Nov 2008 21:08:54 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 03 Nov 2008 21:08:18 +0000 Received: (qmail 22991 invoked from network); 3 Nov 2008 21:08:13 -0000 Received: from unknown (HELO localhost) (vladimir@127.0.0.2) by mail.codesourcery.com with ESMTPA; 3 Nov 2008 21:08:13 -0000 From: Vladimir Prus To: Daniel Jacobowitz Subject: Re: [RFA] Make attach_command exception-safe Date: Mon, 03 Nov 2008 21:08:00 -0000 User-Agent: KMail/1.9.10 Cc: gdb-patches@sources.redhat.com References: <200808291110.43091.vladimir@codesourcery.com> <20080829142418.GA15675@caradoc.them.org> In-Reply-To: <20080829142418.GA15675@caradoc.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200811040008.05287.vladimir@codesourcery.com> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00014.txt.bz2 On Friday 29 August 2008 18:24:18 Daniel Jacobowitz wrote: > On Fri, Aug 29, 2008 at 07:10:42AM +0000, Vladimir Prus wrote: > > > > When attach_command executes, it might disable stdin. It further might > > throw, and does not enable stdin in that case. For CLI case, top-level > > event loop will catch the exception and enable stdin. For MI case, MI > > interpreter catches the exception in order to print the error message, > > and of course it has no idea about any stdin disabling. > > > > This patch makes attach_command exception-safe, enabling stdin on > > throw. > > > > OK? > > OK. I've now checked this in. Thanks, Volodya