Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
		Daniel Jacobowitz <drow@false.org>,
		Pedro Alves <pedro@codesourcery.com>,
	teawater <teawater@gmail.com>
Subject: Re: [RFA] Reverse Debugging, 3/5
Date: Wed, 08 Oct 2008 00:31:00 -0000	[thread overview]
Message-ID: <20081008003058.GB3810@adacore.com> (raw)
In-Reply-To: <48EBADE0.4010405@vmware.com>

HaaaAAAAA, thank you so much for the example, it makes complete sense now.
If you don't mind, and that's only a suggestion, perhaps I would suggest
handle_stepped_backward_into_function for the function name.

> Hmmm.  Well, the question is, do we need to update stop_func_start.
> We don't use it locally, so perhaps we don't need to do it.  But
> I don't really know if we're doing it because someone else will
> maybe need it later.
> 
> It might be an artifact.  But it's not "incorrect", in that
> skipping the prologue is the right thing to do IF you want
> the function start location.

Hmm, you might be right. I'm young and foolish, so I tend to delete code
I'm not sure I need, and only put it back when things do actually break.
I looked at the "handle_inferior_event" code, and it looks like this
field is not used before being recomputed, but it's hard to say for
sure, as you have to also visit the functions being called from there...
Anyway, I was just wondering...

-- 
Joel


      reply	other threads:[~2008-10-08  0:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-01 19:20 Michael Snyder
2008-10-06 20:09 ` Pedro Alves
2008-10-06 20:54   ` Michael Snyder
2008-10-06 21:14     ` Pedro Alves
2008-10-06 21:22       ` Michael Snyder
2008-10-06 21:26       ` Joel Brobecker
2008-10-06 21:47         ` Michael Snyder
2008-10-06 21:22 ` Joel Brobecker
     [not found]   ` <48EA83AD.9040004@vmware.com>
2008-10-06 21:43     ` Joel Brobecker
2008-10-06 23:46       ` Michael Snyder
2008-10-07  4:07         ` Joel Brobecker
2008-10-07 18:46           ` Michael Snyder
2008-10-08  0:31             ` Joel Brobecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081008003058.GB3810@adacore.com \
    --to=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=pedro@codesourcery.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox