Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@adacore.com>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
		Daniel Jacobowitz <drow@false.org>,
		Pedro Alves <pedro@codesourcery.com>,
	teawater <teawater@gmail.com>
Subject: Re: [RFA] Reverse Debugging, 3/5
Date: Mon, 06 Oct 2008 21:43:00 -0000	[thread overview]
Message-ID: <20081006214317.GD21853@adacore.com> (raw)
In-Reply-To: <48EA83AD.9040004@vmware.com>

> But on the other hand, this is exactly what we are doing here.
> We are stepping into a function.  Only we're doing it in
> reverse, so we're coming in thru a return, not thru a call.

I think part of the issue is that, to me, "step_into_function" is
a misleading name for that function, as it implies that we haven't
stepped into the function yet.  So, what the function does is,
now that we've stepped into the function, see if we need to continue
somewhere a little farther or not. So, to me, doing the reverse of
"step_into_function" meant going back to the calling site...

> You still think I should split them up?

At the very least, I think that a comment explaining what the context
and what we need to do would be very useful.  But I also think that
putting the reverse part in its own function would be even clearer.
Your choice, though.

-- 
Joel


  parent reply	other threads:[~2008-10-06 21:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-01 19:20 Michael Snyder
2008-10-06 20:09 ` Pedro Alves
2008-10-06 20:54   ` Michael Snyder
2008-10-06 21:14     ` Pedro Alves
2008-10-06 21:22       ` Michael Snyder
2008-10-06 21:26       ` Joel Brobecker
2008-10-06 21:47         ` Michael Snyder
2008-10-06 21:22 ` Joel Brobecker
     [not found]   ` <48EA83AD.9040004@vmware.com>
2008-10-06 21:43     ` Joel Brobecker [this message]
2008-10-06 23:46       ` Michael Snyder
2008-10-07  4:07         ` Joel Brobecker
2008-10-07 18:46           ` Michael Snyder
2008-10-08  0:31             ` Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081006214317.GD21853@adacore.com \
    --to=brobecker@adacore.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=msnyder@vmware.com \
    --cc=pedro@codesourcery.com \
    --cc=teawater@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox