Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: fix dwarf2read.c offset-is-in-cu calculation
Date: Sun, 05 Oct 2008 16:09:00 -0000	[thread overview]
Message-ID: <20081005160915.GE29968@caradoc.them.org> (raw)
In-Reply-To: <20081004205403.7D5A141267A@localhost>

On Sat, Oct 04, 2008 at 01:54:03PM -0700, Doug Evans wrote:
> Some calculations for whether an offset is within a CU don't take into
> account initial_length_size.
> The error is innocuous because GDB will still lookup the correct CU,
> but it didn't have to do the lookup.  The error also causes the CU
> to be made a dependency of itself which is unnecessary.
> 
> This also changes the name of a label in dw2-intercu.S to improve
> readability.
> 
> Ok to check in?

OK.

-- 
Daniel Jacobowitz
CodeSourcery


      reply	other threads:[~2008-10-05 16:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-04 20:55 Doug Evans
2008-10-05 16:09 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081005160915.GE29968@caradoc.them.org \
    --to=drow@false.org \
    --cc=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox