From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-59018-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 5038 invoked by alias); 5 Oct 2008 16:09:58 -0000
Received: (qmail 5029 invoked by uid 22791); 5 Oct 2008 16:09:57 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 05 Oct 2008 16:09:17 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 183FA1019A; 	Sun,  5 Oct 2008 16:09:16 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 05B5510199; 	Sun,  5 Oct 2008 16:09:16 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1KmWAV-0007vC-GW; Sun, 05 Oct 2008 12:09:15 -0400
Date: Sun, 05 Oct 2008 16:09:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Subject: Re: fix dwarf2read.c offset-is-in-cu calculation
Message-ID: <20081005160915.GE29968@caradoc.them.org>
Mail-Followup-To: Doug Evans <dje@google.com>, gdb-patches@sourceware.org
References: <20081004205403.7D5A141267A@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20081004205403.7D5A141267A@localhost>
User-Agent: Mutt/1.5.17 (2008-05-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-10/txt/msg00134.txt.bz2

On Sat, Oct 04, 2008 at 01:54:03PM -0700, Doug Evans wrote:
> Some calculations for whether an offset is within a CU don't take into
> account initial_length_size.
> The error is innocuous because GDB will still lookup the correct CU,
> but it didn't have to do the lookup.  The error also causes the CU
> to be made a dependency of itself which is unnecessary.
> 
> This also changes the name of a label in dw2-intercu.S to improve
> readability.
> 
> Ok to check in?

OK.

-- 
Daniel Jacobowitz
CodeSourcery