From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: shrink struct minimal_symbol
Date: Wed, 01 Oct 2008 16:26:00 -0000 [thread overview]
Message-ID: <20081001162538.GG3665@adacore.com> (raw)
In-Reply-To: <m3ej3kq1d5.fsf@fleche.redhat.com>
> 2008-09-15 Tom Tromey <tromey@redhat.com>
>
> * xcoffread.c (RECORD_MINIMAL_SYMBOL): Update.
> (scan_xcoff_symtab): Update.
> * mdebugread.c (record_minimal_symbol): Update.
> (parse_partial_symbols): Update.
> * elfread.c (record_minimal_symbol): Update.
> * dbxread.c (record_minimal_symbol): Update.
> * coffread.c (record_minimal_symbol): Update.
> * sh64-tdep.c (MSYMBOL_IS_SPECIAL): Redefine.
> (sh64_elf_make_msymbol_special): Update.
> * mips-tdep.c (mips_elf_make_msymbol_special): Use
> MSYMBOL_TARGET_FLAG_1.
> (mips_elf_make_msymbol_special): Likewise.
> (msymbol_is_special): Likewise.
> * minsyms.c (prim_record_minimal_symbol_and_info): Update.
> (install_minimal_symbols): Likewise.
> (prim_record_minimal_symbol): Update.
> (prim_record_minimal_symbol_and_info): Remove 'info' argument.
> * m68hc11-tdep.c (MSYMBOL_SET_RTC): Redefine.
> (MSYMBOL_SET_RTI): Redefine.
> (MSYMBOL_IS_RTC): Redefine.
> (MSYMBOL_IS_RTI): Redefine.
> * arm-tdep.c (MSYMBOL_SET_SPECIAL): Redefine.
> (MSYMBOL_IS_SPECIAL): Redefine.
> * symtab.h (struct minimal_symbol) <info>: Remove.
> <target_flag_1, target_flag_2>: New fields.
> (MSYMBOL_INFO): Remove.
> (MSYMBOL_TARGET_FLAG_1): New macro.
> (MSYMBOL_TARGET_FLAG_2): Likewise.
> (prim_record_minimal_symbol_and_info): Update.
This looks OK to me. Just a possible typo:
> + /* Two flag bit provided for the use of the target. */
^^^ bits?
:REVIEWMAIL:
--
Joel
next prev parent reply other threads:[~2008-10-01 16:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-16 2:20 Tom Tromey
2008-10-01 16:26 ` Joel Brobecker [this message]
2008-10-01 16:36 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081001162538.GG3665@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox