From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24688 invoked by alias); 1 Oct 2008 16:26:19 -0000 Received: (qmail 24568 invoked by uid 22791); 1 Oct 2008 16:26:18 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 01 Oct 2008 16:25:43 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 9A91A2A96B8; Wed, 1 Oct 2008 12:25:41 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id HlC+cf4t5+I5; Wed, 1 Oct 2008 12:25:41 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 6D6872A96B0; Wed, 1 Oct 2008 12:25:40 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id 55D28E7ACD; Wed, 1 Oct 2008 09:25:38 -0700 (PDT) Date: Wed, 01 Oct 2008 16:26:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: shrink struct minimal_symbol Message-ID: <20081001162538.GG3665@adacore.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-10/txt/msg00016.txt.bz2 > 2008-09-15 Tom Tromey > > * xcoffread.c (RECORD_MINIMAL_SYMBOL): Update. > (scan_xcoff_symtab): Update. > * mdebugread.c (record_minimal_symbol): Update. > (parse_partial_symbols): Update. > * elfread.c (record_minimal_symbol): Update. > * dbxread.c (record_minimal_symbol): Update. > * coffread.c (record_minimal_symbol): Update. > * sh64-tdep.c (MSYMBOL_IS_SPECIAL): Redefine. > (sh64_elf_make_msymbol_special): Update. > * mips-tdep.c (mips_elf_make_msymbol_special): Use > MSYMBOL_TARGET_FLAG_1. > (mips_elf_make_msymbol_special): Likewise. > (msymbol_is_special): Likewise. > * minsyms.c (prim_record_minimal_symbol_and_info): Update. > (install_minimal_symbols): Likewise. > (prim_record_minimal_symbol): Update. > (prim_record_minimal_symbol_and_info): Remove 'info' argument. > * m68hc11-tdep.c (MSYMBOL_SET_RTC): Redefine. > (MSYMBOL_SET_RTI): Redefine. > (MSYMBOL_IS_RTC): Redefine. > (MSYMBOL_IS_RTI): Redefine. > * arm-tdep.c (MSYMBOL_SET_SPECIAL): Redefine. > (MSYMBOL_IS_SPECIAL): Redefine. > * symtab.h (struct minimal_symbol) : Remove. > : New fields. > (MSYMBOL_INFO): Remove. > (MSYMBOL_TARGET_FLAG_1): New macro. > (MSYMBOL_TARGET_FLAG_2): Likewise. > (prim_record_minimal_symbol_and_info): Update. This looks OK to me. Just a possible typo: > + /* Two flag bit provided for the use of the target. */ ^^^ bits? :REVIEWMAIL: -- Joel