From: Pedro Alves <pedro@codesourcery.com>
To: gdb-patches@sourceware.org
Cc: "Sérgio Durigan Júnior" <sergiodj@linux.vnet.ibm.com>
Subject: Re: [PATCH] Fix argument-passing error in linux-nat.c
Date: Thu, 25 Sep 2008 13:53:00 -0000 [thread overview]
Message-ID: <200809251452.19628.pedro@codesourcery.com> (raw)
In-Reply-To: <1222348523.10481.5.camel@miki>
On Thursday 25 September 2008 14:15:23, Sérgio Durigan Júnior wrote:
> This is a very trivial patch that I have done (while I don't have yet
> the 'catch syscall' patch! :D). Well, I found this little error in
> linux-nat.c. Basically, the 'status' variable in the function
> 'get_pending_status' is a pointer to an integer, but the macros from
> waitpid.h (WIFSTOPPED and WSTOPSIG) are being called with this pointer
> as the argument, instead of the integer itself. It was just a matter of
> putting a '*' in the front of the name ;-)
Well, I'll be ... Your change is obviously correct. Can you check it in,
with a ChangeLog entry?
How many typos can one write. :-) Sorry 'bout that.
> This fix did not cause any improvement on the testsuite (for 32-bit PPC
> at least), but anyway it's better to do things right, huh?
You can only trigger this code path in non-stop mode (set
target-async + set non-stop 1), and we don't have any non-stop test
attach/detaching.
--
Pedro Alves
next prev parent reply other threads:[~2008-09-25 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-25 13:21 Sérgio Durigan Júnior
2008-09-25 13:53 ` Pedro Alves [this message]
2008-09-25 17:02 ` Thiago Jung Bauermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809251452.19628.pedro@codesourcery.com \
--to=pedro@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox