From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6367 invoked by alias); 25 Sep 2008 13:53:12 -0000 Received: (qmail 6357 invoked by uid 22791); 25 Sep 2008 13:53:10 -0000 X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 25 Sep 2008 13:52:33 +0000 Received: (qmail 29231 invoked from network); 25 Sep 2008 13:52:31 -0000 Received: from unknown (HELO orlando.local) (pedro@127.0.0.2) by mail.codesourcery.com with ESMTPA; 25 Sep 2008 13:52:31 -0000 From: Pedro Alves To: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix argument-passing error in linux-nat.c Date: Thu, 25 Sep 2008 13:53:00 -0000 User-Agent: KMail/1.9.9 Cc: =?utf-8?q?S=C3=A9rgio_Durigan_J=C3=BAnior?= References: <1222348523.10481.5.camel@miki> In-Reply-To: <1222348523.10481.5.camel@miki> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200809251452.19628.pedro@codesourcery.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00502.txt.bz2 On Thursday 25 September 2008 14:15:23, S=C3=A9rgio Durigan J=C3=BAnior wro= te: > This is a very trivial patch that I have done (while I don't have yet > the 'catch syscall' patch! :D). Well, I found this little error in > linux-nat.c. Basically, the 'status' variable in the function > 'get_pending_status' is a pointer to an integer, but the macros from > waitpid.h (WIFSTOPPED and WSTOPSIG) are being called with this pointer > as the argument, instead of the integer itself. It was just a matter of > putting a '*' in the front of the name ;-) Well, I'll be ... Your change is obviously correct. Can you check it in, with a ChangeLog entry? How many typos can one write. :-) Sorry 'bout that. > This fix did not cause any improvement on the testsuite (for 32-bit PPC > at least), but anyway it's better to do things right, huh?=20 You can only trigger this code path in non-stop mode (set target-async + set non-stop 1), and we don't have any non-stop test=20 attach/detaching. --=20 Pedro Alves