From: Joel Brobecker <brobecker@adacore.com>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFA: implement all missing macro expansion features
Date: Sun, 21 Sep 2008 06:08:00 -0000 [thread overview]
Message-ID: <20080921060737.GE23372@adacore.com> (raw)
In-Reply-To: <m3bpyi5vpw.fsf@fleche.redhat.com>
> I think this patch addresses all your concerns.
Agreed.
> 2008-09-20 Tom Tromey <tromey@redhat.com>
>
> * macrocmd.c (extract_identifier): Add is_parameter argument.
> (macro_define_command): Update.
> (macro_undef_command): Likewise.
> * macroexp.c (stringify): New function.
> (find_parameter): Likewise.
> (gather_arguments): Add nargs argument. Handle varargs.
> (substitute_args): Add is_varargs and va_arg_name arguments.
> Handle varargs, splicing, stringification. Use find_parameter.
> (expand): Handle varargs.
> 2008-09-20 Tom Tromey <tromey@redhat.com>
>
> * gdb.base/macscp.exp: Add tests for stringification, splicing,
> and varargs.
Please wait another couple of days to give others a final chance
to provide their feedback, and then commit.
--
Joel
next prev parent reply other threads:[~2008-09-21 6:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-22 16:01 Tom Tromey
2008-09-20 0:19 ` Joel Brobecker
2008-09-20 4:55 ` Tom Tromey
2008-09-20 15:19 ` Joel Brobecker
2008-09-20 21:56 ` Tom Tromey
2008-09-21 3:13 ` Eli Zaretskii
2008-09-21 3:25 ` Tom Tromey
2008-09-21 18:01 ` Eli Zaretskii
2008-09-21 6:08 ` Joel Brobecker [this message]
2008-09-27 21:39 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080921060737.GE23372@adacore.com \
--to=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox