From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18826 invoked by alias); 21 Sep 2008 06:08:19 -0000 Received: (qmail 18818 invoked by uid 22791); 21 Sep 2008 06:08:18 -0000 X-Spam-Check-By: sourceware.org Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 21 Sep 2008 06:07:44 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 322562A9687; Sun, 21 Sep 2008 02:07:42 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id OnDjXV4yLr7d; Sun, 21 Sep 2008 02:07:42 -0400 (EDT) Received: from joel.gnat.com (localhost.localdomain [127.0.0.1]) by rock.gnat.com (Postfix) with ESMTP id 5EC112A9625; Sun, 21 Sep 2008 02:07:40 -0400 (EDT) Received: by joel.gnat.com (Postfix, from userid 1000) id A836CE7ACD; Sat, 20 Sep 2008 23:07:37 -0700 (PDT) Date: Sun, 21 Sep 2008 06:08:00 -0000 From: Joel Brobecker To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: RFA: implement all missing macro expansion features Message-ID: <20080921060737.GE23372@adacore.com> References: <20080920001852.GC23372@adacore.com> <20080920151859.GD23372@adacore.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.2i Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00452.txt.bz2 > I think this patch addresses all your concerns. Agreed. > 2008-09-20 Tom Tromey > > * macrocmd.c (extract_identifier): Add is_parameter argument. > (macro_define_command): Update. > (macro_undef_command): Likewise. > * macroexp.c (stringify): New function. > (find_parameter): Likewise. > (gather_arguments): Add nargs argument. Handle varargs. > (substitute_args): Add is_varargs and va_arg_name arguments. > Handle varargs, splicing, stringification. Use find_parameter. > (expand): Handle varargs. > 2008-09-20 Tom Tromey > > * gdb.base/macscp.exp: Add tests for stringification, splicing, > and varargs. Please wait another couple of days to give others a final chance to provide their feedback, and then commit. -- Joel