From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 02/08] multi-process support: all targets manage inferior list
Date: Thu, 18 Sep 2008 22:52:00 -0000 [thread overview]
Message-ID: <20080918225118.GD1691@caradoc.them.org> (raw)
In-Reply-To: <200809121638.18399.pedro@codesourcery.com>
On Fri, Sep 12, 2008 at 04:38:18PM +0100, Pedro Alves wrote:
> @@ -662,6 +662,9 @@ go32_create_inferior (char *exec_file, c
> #endif
>
> inferior_ptid = pid_to_ptid (SOME_PID);
> + add_inferior (SOME_PID);
> + add_thread_silent (inferior_ptid);
> +
> push_target (&go32_ops);
>
> add_thread_silent (inferior_ptid);
Is the new add_thread_silent a typo, or did you mean to remove the
second call?
This looks otherwise OK (though I don't understand when you use
add_inferior vs add_inferior_silent).
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-09-18 22:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 15:38 Pedro Alves
2008-09-18 22:52 ` Daniel Jacobowitz [this message]
2008-09-19 13:59 ` Pedro Alves
2008-09-19 14:08 ` Daniel Jacobowitz
2008-09-19 15:28 ` Eli Zaretskii
2008-09-22 15:43 ` Pedro Alves
2008-09-22 19:01 ` Eli Zaretskii
2008-09-22 19:02 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080918225118.GD1691@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox