From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-58687-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 18971 invoked by alias); 18 Sep 2008 22:52:06 -0000
Received: (qmail 18963 invoked by uid 22791); 18 Sep 2008 22:52:05 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 18 Sep 2008 22:51:21 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id BDD9F10004; 	Thu, 18 Sep 2008 22:51:19 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 7FA9D10003; 	Thu, 18 Sep 2008 22:51:19 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1KgSLG-0006Oj-Pd; Thu, 18 Sep 2008 18:51:18 -0400
Date: Thu, 18 Sep 2008 22:52:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA 02/08] multi-process support: all targets manage inferior 	list
Message-ID: <20080918225118.GD1691@caradoc.them.org>
Mail-Followup-To: Pedro Alves <pedro@codesourcery.com>, 	gdb-patches@sourceware.org
References: <200809121638.18399.pedro@codesourcery.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200809121638.18399.pedro@codesourcery.com>
User-Agent: Mutt/1.5.17 (2008-05-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-09/txt/msg00398.txt.bz2

On Fri, Sep 12, 2008 at 04:38:18PM +0100, Pedro Alves wrote:
> @@ -662,6 +662,9 @@ go32_create_inferior (char *exec_file, c
>  #endif
>  
>    inferior_ptid = pid_to_ptid (SOME_PID);
> +  add_inferior (SOME_PID);
> +  add_thread_silent (inferior_ptid);
> +
>    push_target (&go32_ops);
>  
>    add_thread_silent (inferior_ptid);

Is the new add_thread_silent a typo, or did you mean to remove the
second call?

This looks otherwise OK (though I don't understand when you use
add_inferior vs add_inferior_silent).

-- 
Daniel Jacobowitz
CodeSourcery