From: Daniel Jacobowitz <drow@false.org>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Pedro Alves <pedro@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix a crash on NULL event_thread
Date: Wed, 17 Sep 2008 18:04:00 -0000 [thread overview]
Message-ID: <20080917180337.GA10202@caradoc.them.org> (raw)
In-Reply-To: <20080912221227.GA5848@host0.dyn.jankratochvil.net>
On Sat, Sep 13, 2008 at 12:12:27AM +0200, Jan Kratochvil wrote:
> 2008-09-13 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Fix a crash on uninitialized ECS->EVENT_THREAD for a newly found thread.
> * infrun.c (wait_for_inferior): Move this ECS->EVENT_THREAD
> initialization ...
> (fetch_inferior_event): ... and this ECS->EVENT_THREAD initialization
> ...
> (handle_inferior_event): ... here after ADD_THREAD together with the
> local ADJUST_PC_AFTER_BREAK call.
Please move the reinit_frame_cache call so it is still right after
adjust_pc_after_break. Also, no need to capitalize
adjust_pc_after_break; this is like the texinfo @var{} markup. You
capitalize FOO when you mean "the value of a variable named foo",
but the name of the variable is still "foo".
Otherwise looks OK, thanks.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-09-17 18:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-12 22:17 Jan Kratochvil
2008-09-12 22:45 ` Pedro Alves
2008-09-15 18:59 ` Jan Kratochvil
2008-09-17 15:55 ` Pedro Alves
2008-09-17 18:04 ` Daniel Jacobowitz [this message]
2008-09-17 21:56 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080917180337.GA10202@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox