From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3016 invoked by alias); 17 Sep 2008 18:04:22 -0000 Received: (qmail 3007 invoked by uid 22791); 17 Sep 2008 18:04:22 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 17 Sep 2008 18:03:41 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 17A1E10CF4; Wed, 17 Sep 2008 18:03:39 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id EB9D210CF2; Wed, 17 Sep 2008 18:03:38 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1Kg1NJ-0002om-O2; Wed, 17 Sep 2008 14:03:37 -0400 Date: Wed, 17 Sep 2008 18:04:00 -0000 From: Daniel Jacobowitz To: Jan Kratochvil Cc: Pedro Alves , gdb-patches@sourceware.org Subject: Re: [patch] Fix a crash on NULL event_thread Message-ID: <20080917180337.GA10202@caradoc.them.org> Mail-Followup-To: Jan Kratochvil , Pedro Alves , gdb-patches@sourceware.org References: <20080912221227.GA5848@host0.dyn.jankratochvil.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080912221227.GA5848@host0.dyn.jankratochvil.net> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00374.txt.bz2 On Sat, Sep 13, 2008 at 12:12:27AM +0200, Jan Kratochvil wrote: > 2008-09-13 Jan Kratochvil > > Fix a crash on uninitialized ECS->EVENT_THREAD for a newly found thread. > * infrun.c (wait_for_inferior): Move this ECS->EVENT_THREAD > initialization ... > (fetch_inferior_event): ... and this ECS->EVENT_THREAD initialization > ... > (handle_inferior_event): ... here after ADD_THREAD together with the > local ADJUST_PC_AFTER_BREAK call. Please move the reinit_frame_cache call so it is still right after adjust_pc_after_break. Also, no need to capitalize adjust_pc_after_break; this is like the texinfo @var{} markup. You capitalize FOO when you mean "the value of a variable named foo", but the name of the variable is still "foo". Otherwise looks OK, thanks. -- Daniel Jacobowitz CodeSourcery