From: Daniel Jacobowitz <drow@false.org>
To: Michael Snyder <msnyder@vmware.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
teawater <teawater@gmail.com>
Subject: Re: [reverse RFA] no singlestep-over-BP in reverse
Date: Mon, 15 Sep 2008 18:43:00 -0000 [thread overview]
Message-ID: <20080915184245.GA21388@caradoc.them.org> (raw)
In-Reply-To: <48CEAA05.8050006@vmware.com>
On Mon, Sep 15, 2008 at 11:31:33AM -0700, Michael Snyder wrote:
> When we're stopped at a breakpoint and we want to
> continue in reverse, we're not actually going to
> execute the instruction at the breakpoint -- we're
> going to de-execute the previous instruction.
>
> Therefore there's no need to singlestep before
> inserting breakpoints. In fact it would be a bad
> idea to do so, because if there is a breakpoint at
> the previous instruction, we WANT to hit it.
>
> Note that this patch is to be applied to the reverse branch.
If there is a breakpoint on the previous instruction, will you hit it
before or after de-executing that instruction? It seems like this
logic should be somehow still necessary... but I can't put my finger
on when.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-09-15 18:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-15 18:33 Michael Snyder
2008-09-15 18:43 ` Daniel Jacobowitz [this message]
2008-09-15 19:07 ` Michael Snyder
2008-09-15 21:15 ` Daniel Jacobowitz
2008-09-15 23:09 ` Michael Snyder
2008-09-16 0:09 ` Michael Snyder
2008-09-16 4:13 ` teawater
[not found] ` <daef60380809152110u663350abx76b283d519c5a09d@mail.gmail.com>
2008-09-16 18:40 ` Michael Snyder
2008-09-16 4:22 ` teawater
2008-09-16 15:04 ` teawater
2008-09-16 15:14 ` teawater
2008-09-16 15:22 ` Daniel Jacobowitz
2008-09-16 15:34 ` teawater
2008-09-16 15:35 ` teawater
2008-09-16 18:50 ` Michael Snyder
2008-09-16 18:45 ` Michael Snyder
2008-09-16 20:11 ` Joel Brobecker
2008-09-17 0:56 ` Michael Snyder
2008-09-17 15:44 ` teawater
2008-09-17 18:18 ` Michael Snyder
2008-09-17 15:32 ` teawater
2008-09-17 18:16 ` Michael Snyder
2008-09-18 6:39 ` teawater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080915184245.GA21388@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=msnyder@vmware.com \
--cc=teawater@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox