Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: guitton@adacore.com (Jerome Guitton)
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Fix testcase for SPU (Re: [RFA/testsuite] stack check)
Date: Thu, 11 Sep 2008 18:12:00 -0000	[thread overview]
Message-ID: <200809111811.m8BIBBNr007816@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20080911163439.GB35787@adacore.com> from "Jerome Guitton" at Sep 11, 2008 06:34:39 PM

Jeroms Guitton wrote:

> Ulrich Weigand (uweigand@de.ibm.com):
> 
> > Jerome Guitton wrote:
> > 
> > > void big_frame ()
> > > {
> > >   char S [524188];
> > >   small_frame ();
> > > }
> > 
> > This breaks on the SPU where we only have 256 KB local store.
> 
> 
> Sorry about that. I guess that this may break other configurations;
> maybe we should enable this test on a limited set of targets?

Hmm, the GCC testsuite supports a gcc,stack_size target_info property
and modified the behaviour of some test cases depending on that info.
Maybe we want to use something like that in GDB as well ...

But for now, I'd be fine with either leaving this particular as is
and see if other platforms complain, or else restrict it only those
platforms it is supposed to be testing (the particular levels of
frame size where prologue code generation changes is platform-specific
anyway).

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


      reply	other threads:[~2008-09-11 18:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 17:03 [RFA/testsuite] stack check Jerome Guitton
2008-09-01 17:14 ` Jerome Guitton
2008-09-02 21:03   ` Joel Brobecker
2008-09-02 21:02 ` Joel Brobecker
2008-09-03  8:53   ` Jerome Guitton
2008-09-08 10:17   ` Jerome Guitton
2008-09-08 15:42     ` Joel Brobecker
2008-09-08 15:56       ` Jerome Guitton
2008-09-11 16:26 ` [commit] Fix testcase for SPU (Re: [RFA/testsuite] stack check) Ulrich Weigand
2008-09-11 16:35   ` Jerome Guitton
2008-09-11 18:12     ` Ulrich Weigand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809111811.m8BIBBNr007816@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guitton@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox