Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: guitton@adacore.com (Jerome Guitton)
Cc: gdb-patches@sourceware.org
Subject: [commit] Fix testcase for SPU (Re: [RFA/testsuite] stack check)
Date: Thu, 11 Sep 2008 16:26:00 -0000	[thread overview]
Message-ID: <200809111626.m8BGQ4Mw020176@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20080901170203.GB226@adacore.com> from "Jerome Guitton" at Sep 01, 2008 07:02:03 PM

Jerome Guitton wrote:

> void big_frame ()
> {
>   char S [524188];
>   small_frame ();
> }

This breaks on the SPU where we only have 256 KB local store.

I've committed the following patch to reduce stack consumption
on the SPU.

Bye,
Ulrich


ChangeLog:

	* gdb.base/stack-checking.c (big_frame): Reduce stack consumption
	on SPU.

Index: gdb/testsuite/gdb.base/stack-checking.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/stack-checking.c,v
retrieving revision 1.1
diff -c -p -r1.1 stack-checking.c
*** gdb/testsuite/gdb.base/stack-checking.c	8 Sep 2008 15:54:29 -0000	1.1
--- gdb/testsuite/gdb.base/stack-checking.c	11 Sep 2008 16:20:29 -0000
*************** void medium_frame ()
*** 36,42 ****
--- 36,46 ----
  
  void big_frame ()
  {
+ #ifdef __SPU__
+   char S [131072];
+ #else
    char S [524188];
+ #endif
    small_frame ();
  }
  


-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  parent reply	other threads:[~2008-09-11 16:26 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-01 17:03 [RFA/testsuite] stack check Jerome Guitton
2008-09-01 17:14 ` Jerome Guitton
2008-09-02 21:03   ` Joel Brobecker
2008-09-02 21:02 ` Joel Brobecker
2008-09-03  8:53   ` Jerome Guitton
2008-09-08 10:17   ` Jerome Guitton
2008-09-08 15:42     ` Joel Brobecker
2008-09-08 15:56       ` Jerome Guitton
2008-09-11 16:26 ` Ulrich Weigand [this message]
2008-09-11 16:35   ` [commit] Fix testcase for SPU (Re: [RFA/testsuite] stack check) Jerome Guitton
2008-09-11 18:12     ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200809111626.m8BGQ4Mw020176@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=gdb-patches@sourceware.org \
    --cc=guitton@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox