From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: dje@google.com (Doug Evans)
Cc: gdb-patches@sourceware.org
Subject: Re: [RFA] rename paddr_[du] to p{,u}longest
Date: Thu, 04 Sep 2008 20:34:00 -0000 [thread overview]
Message-ID: <200809042034.m84KY7e9007727@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20080904192543.461661C7892@localhost> from "Doug Evans" at Sep 04, 2008 12:25:43 PM
Doug Evans wrote:
> Hi. paddr_[du] claim to print addresses (CORE_ADDR) given their name but they
> are really intended to support printing {,U}LONGEST values.
> This patch renames them to plongest/pulongest, and changes the type of
> the unsigned printer from CORE_ADDR to ULONGEST to support printing
> 64 bit unsigned values when CORE_ADDR is 32-bits (decimal2str takes
> a ULONGEST parameter so there's no real reason why pulongest(/paddr_u)
> can't take a ULONGEST too).
Agreed. This has annoyed me on occasion as well ...
> 2008-09-04 Doug Evans <dje@google.com>
>
> * defs.h (plongest,pulongest): Renamed from paddr_u,paddr_d.
> Change argument of pulongest from CORE_ADDR to ULONGEST.
> All callers updated.
> * utils.c (plongest): Renamed from paddr_d.
> (pulongest): Renamed from paddr_u, change arg type to ULONGEST.
> * remote-mips.c (send_srec): Use paddr_nz instead of paddr_u in
> `CORE_ADDR addr' arg of error message.
This is OK.
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
prev parent reply other threads:[~2008-09-04 20:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-04 19:26 Doug Evans
2008-09-04 20:34 ` Ulrich Weigand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200809042034.m84KY7e9007727@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=dje@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox