From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6756 invoked by alias); 4 Sep 2008 20:34:57 -0000 Received: (qmail 6745 invoked by uid 22791); 4 Sep 2008 20:34:56 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate4.de.ibm.com (HELO mtagate4.de.ibm.com) (195.212.29.153) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 04 Sep 2008 20:34:13 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate4.de.ibm.com (8.13.8/8.13.8) with ESMTP id m84KYAmf211612 for ; Thu, 4 Sep 2008 20:34:10 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m84KYA0R3776630 for ; Thu, 4 Sep 2008 22:34:10 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m84KY78A007730 for ; Thu, 4 Sep 2008 22:34:07 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m84KY7e9007727; Thu, 4 Sep 2008 22:34:07 +0200 Message-Id: <200809042034.m84KY7e9007727@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 4 Sep 2008 22:34:07 +0200 Subject: Re: [RFA] rename paddr_[du] to p{,u}longest To: dje@google.com (Doug Evans) Date: Thu, 04 Sep 2008 20:34:00 -0000 From: "Ulrich Weigand" Cc: gdb-patches@sourceware.org In-Reply-To: <20080904192543.461661C7892@localhost> from "Doug Evans" at Sep 04, 2008 12:25:43 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-09/txt/msg00072.txt.bz2 Doug Evans wrote: > Hi. paddr_[du] claim to print addresses (CORE_ADDR) given their name but they > are really intended to support printing {,U}LONGEST values. > This patch renames them to plongest/pulongest, and changes the type of > the unsigned printer from CORE_ADDR to ULONGEST to support printing > 64 bit unsigned values when CORE_ADDR is 32-bits (decimal2str takes > a ULONGEST parameter so there's no real reason why pulongest(/paddr_u) > can't take a ULONGEST too). Agreed. This has annoyed me on occasion as well ... > 2008-09-04 Doug Evans > > * defs.h (plongest,pulongest): Renamed from paddr_u,paddr_d. > Change argument of pulongest from CORE_ADDR to ULONGEST. > All callers updated. > * utils.c (plongest): Renamed from paddr_d. > (pulongest): Renamed from paddr_u, change arg type to ULONGEST. > * remote-mips.c (send_srec): Use paddr_nz instead of paddr_u in > `CORE_ADDR addr' arg of error message. This is OK. Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com