From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: gdb-patches@sourceware.org
Cc: drow@false.org (Daniel Jacobowitz)
Subject: Re: [rfc, v3] Fix frame_id_inner comparison false positives
Date: Tue, 26 Aug 2008 17:46:00 -0000 [thread overview]
Message-ID: <200808261741.m7QHfDuQ000784@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200808220143.m7M1hiVE005244@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Aug 22, 2008 03:43:44 AM
> ChangeLog:
>
> * dummy-frame.h (dummy_frame_pop): Add prototype.
> * dummy-frame.c: Include "observer.h".
> (dummy_frame_push): Do not check for stale frames.
> (dummy_frame_pop): New function.
> (cleanup_dummy_frames): New function.
> (_initialize_dummy_frame): Install it as inferior_created observer.
>
> * frame.h (struct frame_id): Update comments.
> (frame_id_inner): Remove prototype.
> * frame.c (frame_id_inner): Make static. Add comments.
> (frame_find_by_id): Update frame_id_inner safety net check to avoid
> false positives for targets using non-contiguous stack ranges.
> (get_prev_frame_1): Update frame_id_inner safety net check.
> (frame_pop): Call dummy_frame_pop when popping a dummy frame.
>
> * stack.c (return_command): Directly pop the selected frame.
> * infrun.c (handle_inferior_event): Remove dead code.
> * i386-tdep.c (i386_push_dummy_call): Update comment.
This is now checked in too.
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2008-08-26 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-20 4:42 [rfc] Eliminate frame_id_inner comparisons Ulrich Weigand
2008-06-25 13:32 ` Joel Brobecker
2008-06-25 14:15 ` Daniel Jacobowitz
2008-08-21 19:43 ` [rfc, v2] Fix frame_id_inner comparison false positives Ulrich Weigand
2008-08-21 20:16 ` Daniel Jacobowitz
2008-08-21 21:47 ` [rfc, v3] " Ulrich Weigand
2008-08-22 1:45 ` Ulrich Weigand
2008-08-26 17:46 ` Ulrich Weigand [this message]
2008-08-26 22:19 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808261741.m7QHfDuQ000784@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox