From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10288 invoked by alias); 26 Aug 2008 17:46:29 -0000 Received: (qmail 10251 invoked by uid 22791); 26 Aug 2008 17:46:29 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate8.de.ibm.com (HELO mtagate8.de.ibm.com) (195.212.29.157) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 26 Aug 2008 17:41:47 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate8.de.ibm.com (8.13.8/8.13.8) with ESMTP id m7QHfHPZ094126 for ; Tue, 26 Aug 2008 17:41:17 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7QHfHWK3555374 for ; Tue, 26 Aug 2008 19:41:17 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7QHfDAW000787 for ; Tue, 26 Aug 2008 19:41:13 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m7QHfDuQ000784; Tue, 26 Aug 2008 19:41:13 +0200 Message-Id: <200808261741.m7QHfDuQ000784@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 26 Aug 2008 19:41:13 +0200 Subject: Re: [rfc, v3] Fix frame_id_inner comparison false positives To: gdb-patches@sourceware.org Date: Tue, 26 Aug 2008 17:46:00 -0000 From: "Ulrich Weigand" Cc: drow@false.org (Daniel Jacobowitz) In-Reply-To: <200808220143.m7M1hiVE005244@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Aug 22, 2008 03:43:44 AM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00625.txt.bz2 > ChangeLog: > > * dummy-frame.h (dummy_frame_pop): Add prototype. > * dummy-frame.c: Include "observer.h". > (dummy_frame_push): Do not check for stale frames. > (dummy_frame_pop): New function. > (cleanup_dummy_frames): New function. > (_initialize_dummy_frame): Install it as inferior_created observer. > > * frame.h (struct frame_id): Update comments. > (frame_id_inner): Remove prototype. > * frame.c (frame_id_inner): Make static. Add comments. > (frame_find_by_id): Update frame_id_inner safety net check to avoid > false positives for targets using non-contiguous stack ranges. > (get_prev_frame_1): Update frame_id_inner safety net check. > (frame_pop): Call dummy_frame_pop when popping a dummy frame. > > * stack.c (return_command): Directly pop the selected frame. > * infrun.c (handle_inferior_event): Remove dead code. > * i386-tdep.c (i386_push_dummy_call): Update comment. This is now checked in too. Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com