From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: gdb-patches@sourceware.org
Subject: [PATCH] powerpc-prologue.exp
Date: Wed, 20 Aug 2008 14:20:00 -0000 [thread overview]
Message-ID: <200808201420.m7KEKBV6028041@brahms.sibelius.xs4all.nl> (raw)
While running the testsuite on openbsd4.4-unknown-powerpc, I spotted
the following new fail:
+FAIL: gdb.arch/powerpc-prologue.exp: saved registers in PIC
The problem is that "info frame" no longer reports r31 as saved. As
far as I can tell, the assembly code doesn't actually save r31, so I
suspect this is actually a bug in the testcase that got uncovered by
the following fix by Daniel:
2008-08-18 Daniel Jacobowitz <dan@codesourcery.com>
* rs6000-tdep.c (struct rs6000_framedata): Add gpr_mask, used_bl,
lr_register.
(rs6000_in_function_epilogue_p): Check for bctr.
(skip_prologue): Initialize lr_register. Set lr_reg to a register
number. Set gpr_mask and used_bl. Continue scanning while some
expected registers are not saved. Set lr_register if LR is not
stored.
(rs6000_frame_cache): Handle gpr_mask and lr_register.
So the following testsuite fix seems to be appropriate. ok?
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* gdb.arch/powerpc-prologue.exp: Code doesn't save %r31 so don't
expect to find it in the "info frame" output.
Index: gdb.arch/powerpc-prologue.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/powerpc-prologue.exp,v
retrieving revision 1.6
diff -u -p -r1.6 powerpc-prologue.exp
--- gdb.arch/powerpc-prologue.exp 18 Aug 2008 12:32:47 -0000 1.6
+++ gdb.arch/powerpc-prologue.exp 20 Aug 2008 14:14:44 -0000
@@ -64,7 +64,7 @@ gdb_test "backtrace 10" \
"backtrace in PIC"
gdb_test "info frame" \
- ".*Saved registers:.*r30 at.*r31 at.*pc at.*lr at.*" \
+ ".*Saved registers:.*r30 at.*pc at.*lr at.*" \
"saved registers in PIC"
# Testcase for scheduled prologue.
next reply other threads:[~2008-08-20 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-20 14:20 Mark Kettenis [this message]
2008-08-20 14:46 ` Daniel Jacobowitz
2008-08-20 15:03 ` Mark Kettenis
2008-08-20 15:10 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808201420.m7KEKBV6028041@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox