From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22130 invoked by alias); 20 Aug 2008 14:20:51 -0000 Received: (qmail 22119 invoked by uid 22791); 20 Aug 2008 14:20:50 -0000 X-Spam-Check-By: sourceware.org Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 20 Aug 2008 14:20:15 +0000 Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id m7KEKBZl010186 for ; Wed, 20 Aug 2008 16:20:11 +0200 (CEST) Received: (from kettenis@localhost) by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id m7KEKBV6028041; Wed, 20 Aug 2008 16:20:11 +0200 (CEST) Date: Wed, 20 Aug 2008 14:20:00 -0000 Message-Id: <200808201420.m7KEKBV6028041@brahms.sibelius.xs4all.nl> From: Mark Kettenis To: gdb-patches@sourceware.org Subject: [PATCH] powerpc-prologue.exp Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00540.txt.bz2 While running the testsuite on openbsd4.4-unknown-powerpc, I spotted the following new fail: +FAIL: gdb.arch/powerpc-prologue.exp: saved registers in PIC The problem is that "info frame" no longer reports r31 as saved. As far as I can tell, the assembly code doesn't actually save r31, so I suspect this is actually a bug in the testcase that got uncovered by the following fix by Daniel: 2008-08-18 Daniel Jacobowitz * rs6000-tdep.c (struct rs6000_framedata): Add gpr_mask, used_bl, lr_register. (rs6000_in_function_epilogue_p): Check for bctr. (skip_prologue): Initialize lr_register. Set lr_reg to a register number. Set gpr_mask and used_bl. Continue scanning while some expected registers are not saved. Set lr_register if LR is not stored. (rs6000_frame_cache): Handle gpr_mask and lr_register. So the following testsuite fix seems to be appropriate. ok? Index: ChangeLog from Mark Kettenis * gdb.arch/powerpc-prologue.exp: Code doesn't save %r31 so don't expect to find it in the "info frame" output. Index: gdb.arch/powerpc-prologue.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/powerpc-prologue.exp,v retrieving revision 1.6 diff -u -p -r1.6 powerpc-prologue.exp --- gdb.arch/powerpc-prologue.exp 18 Aug 2008 12:32:47 -0000 1.6 +++ gdb.arch/powerpc-prologue.exp 20 Aug 2008 14:14:44 -0000 @@ -64,7 +64,7 @@ gdb_test "backtrace 10" \ "backtrace in PIC" gdb_test "info frame" \ - ".*Saved registers:.*r30 at.*r31 at.*pc at.*lr at.*" \ + ".*Saved registers:.*r30 at.*pc at.*lr at.*" \ "saved registers in PIC" # Testcase for scheduled prologue.