From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: uweigand@de.ibm.com (Ulrich Weigand)
Cc: luisgpm@linux.vnet.ibm.com,
bauerman@br.ibm.com (Thiago Jung Bauermann),
gdb-patches@sourceware.org
Subject: Re: [PATCH-ppc 1/5] Add basic support for new VSX register set
Date: Thu, 14 Aug 2008 20:01:00 -0000 [thread overview]
Message-ID: <200808141959.m7EJx8Ki029862@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <200808141949.m7EJnSJE020136@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Aug 14, 2008 09:49:28 PM
> > + t = init_composite_type ("__ppc_builtin_type_vec128", TYPE_CODE_UNION);
> > + append_composite_type_field (t, "uint128", builtin_type_uint128);
> > + append_composite_type_field (t, "v4_float",
> > + init_vector_type (builtin_type_float, 4));
> > + append_composite_type_field (t, "v4_int32",
> > + init_vector_type (builtin_type_int32, 4));
> > + append_composite_type_field (t, "v8_int16",
> > + init_vector_type (builtin_type_int16, 8));
> > + append_composite_type_field (t, "v16_int8",
> > + init_vector_type (builtin_type_int8, 16));
>
> Please use builtin_type (gdbarch)->builtin_... instead of builtin_type_...
> I'm just trying to get rid of those ...
This might have been a bit confusing: the platform-independent types like
builtin_type_int8 are of course fine to use. I was referring to the
platform-dependent types like builtin_type_float (and builtin_type_double
that you're using elsewhere).
Bye,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2008-08-14 20:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-25 20:16 Luis Machado
[not found] ` <1217646694.26214.3.camel@localhost.localdomain>
2008-08-08 15:12 ` Luis Machado
2008-08-08 15:22 ` Luis Machado
2008-08-14 19:50 ` Ulrich Weigand
2008-08-14 20:01 ` Ulrich Weigand [this message]
2008-08-15 5:11 ` Luis Machado
2008-08-15 11:17 ` Ulrich Weigand
2008-08-15 15:27 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808141959.m7EJx8Ki029862@d12av02.megacenter.de.ibm.com \
--to=uweigand@de.ibm.com \
--cc=bauerman@br.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=luisgpm@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox