From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20098 invoked by alias); 14 Aug 2008 20:01:00 -0000 Received: (qmail 20089 invoked by uid 22791); 14 Aug 2008 20:00:59 -0000 X-Spam-Check-By: sourceware.org Received: from mtagate5.de.ibm.com (HELO mtagate5.de.ibm.com) (195.212.29.154) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Aug 2008 20:00:15 +0000 Received: from d12nrmr1607.megacenter.de.ibm.com (d12nrmr1607.megacenter.de.ibm.com [9.149.167.49]) by mtagate5.de.ibm.com (8.13.8/8.13.8) with ESMTP id m7EJx9df383576 for ; Thu, 14 Aug 2008 19:59:09 GMT Received: from d12av02.megacenter.de.ibm.com (d12av02.megacenter.de.ibm.com [9.149.165.228]) by d12nrmr1607.megacenter.de.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7EJx9Jc3285236 for ; Thu, 14 Aug 2008 21:59:09 +0200 Received: from d12av02.megacenter.de.ibm.com (loopback [127.0.0.1]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7EJx8TG029865 for ; Thu, 14 Aug 2008 21:59:09 +0200 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d12av02.megacenter.de.ibm.com (8.12.11.20060308/8.12.11) with SMTP id m7EJx8Ki029862; Thu, 14 Aug 2008 21:59:08 +0200 Message-Id: <200808141959.m7EJx8Ki029862@d12av02.megacenter.de.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Thu, 14 Aug 2008 21:59:08 +0200 Subject: Re: [PATCH-ppc 1/5] Add basic support for new VSX register set To: uweigand@de.ibm.com (Ulrich Weigand) Date: Thu, 14 Aug 2008 20:01:00 -0000 From: "Ulrich Weigand" Cc: luisgpm@linux.vnet.ibm.com, bauerman@br.ibm.com (Thiago Jung Bauermann), gdb-patches@sourceware.org In-Reply-To: <200808141949.m7EJnSJE020136@d12av02.megacenter.de.ibm.com> from "Ulrich Weigand" at Aug 14, 2008 09:49:28 PM X-Mailer: ELM [version 2.5 PL2] MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00384.txt.bz2 > > + t = init_composite_type ("__ppc_builtin_type_vec128", TYPE_CODE_UNION); > > + append_composite_type_field (t, "uint128", builtin_type_uint128); > > + append_composite_type_field (t, "v4_float", > > + init_vector_type (builtin_type_float, 4)); > > + append_composite_type_field (t, "v4_int32", > > + init_vector_type (builtin_type_int32, 4)); > > + append_composite_type_field (t, "v8_int16", > > + init_vector_type (builtin_type_int16, 8)); > > + append_composite_type_field (t, "v16_int8", > > + init_vector_type (builtin_type_int8, 16)); > > Please use builtin_type (gdbarch)->builtin_... instead of builtin_type_... > I'm just trying to get rid of those ... This might have been a bit confusing: the platform-independent types like builtin_type_int8 are of course fine to use. I was referring to the platform-dependent types like builtin_type_float (and builtin_type_double that you're using elsewhere). Bye, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com