Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: Fix crash on "quit" + TUI + remote + async
Date: Thu, 14 Aug 2008 17:52:00 -0000	[thread overview]
Message-ID: <20080814175154.GD15804@caradoc.them.org> (raw)
In-Reply-To: <200807281633.41104.pedro@codesourcery.com>

On Mon, Jul 28, 2008 at 04:33:40PM +0100, Pedro Alves wrote:
> Index: src/gdb/top.c
> ===================================================================
> --- src.orig/gdb/top.c	2008-07-28 16:24:06.000000000 +0100
> +++ src/gdb/top.c	2008-07-28 16:30:48.000000000 +0100
> @@ -1229,8 +1229,9 @@ quit_target (void *arg)
>          target_kill ();
>      }
>  
> -  /* UDI wants this, to kill the TIP.  */
> -  target_close (&current_target, 1);
> +  /* Give all pushed targets a chance to do minimal cleanup, and pop
> +     them all out.  */
> +  pop_all_targets (1);
>  
>    /* Save the history information if it is appropriate to do so.  */
>    if (write_history_p && history_filename)

This patch is OK.  I'm just wondering, though, if you really want to
pop all the way down to exec_stratum; isn't that useless?  It depends
where else you want pop_all_targets, probably.

-- 
Daniel Jacobowitz
CodeSourcery


  parent reply	other threads:[~2008-08-14 17:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-28 15:34 Pedro Alves
2008-07-28 15:52 ` Pedro Alves
2008-08-14 17:52 ` Daniel Jacobowitz [this message]
2008-08-16 22:13   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080814175154.GD15804@caradoc.them.org \
    --to=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox