From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30344 invoked by alias); 14 Aug 2008 17:52:59 -0000 Received: (qmail 30334 invoked by uid 22791); 14 Aug 2008 17:52:58 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 14 Aug 2008 17:51:56 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 55F2A983B4; Thu, 14 Aug 2008 17:51:55 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id 4120598243; Thu, 14 Aug 2008 17:51:55 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KTgzK-0004Ge-Ko; Thu, 14 Aug 2008 13:51:54 -0400 Date: Thu, 14 Aug 2008 17:52:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: Fix crash on "quit" + TUI + remote + async Message-ID: <20080814175154.GD15804@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200807281633.41104.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807281633.41104.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00371.txt.bz2 On Mon, Jul 28, 2008 at 04:33:40PM +0100, Pedro Alves wrote: > Index: src/gdb/top.c > =================================================================== > --- src.orig/gdb/top.c 2008-07-28 16:24:06.000000000 +0100 > +++ src/gdb/top.c 2008-07-28 16:30:48.000000000 +0100 > @@ -1229,8 +1229,9 @@ quit_target (void *arg) > target_kill (); > } > > - /* UDI wants this, to kill the TIP. */ > - target_close (¤t_target, 1); > + /* Give all pushed targets a chance to do minimal cleanup, and pop > + them all out. */ > + pop_all_targets (1); > > /* Save the history information if it is appropriate to do so. */ > if (write_history_p && history_filename) This patch is OK. I'm just wondering, though, if you really want to pop all the way down to exec_stratum; isn't that useless? It depends where else you want pop_all_targets, probably. -- Daniel Jacobowitz CodeSourcery