Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "John David Anglin" <dave@hiauly1.hia.nrc.ca>
To: drow@false.org (Daniel Jacobowitz)
Cc: pedro@codesourcery.com, gdb-patches@sourceware.org
Subject: Re: [4/7] Adjust the ttrace target (HP-UX) to always register the
Date: Sun, 10 Aug 2008 00:36:00 -0000	[thread overview]
Message-ID: <20080810003551.47C854DCB@hiauly1.hia.nrc.ca> (raw)
In-Reply-To: <20080810001447.GB22119@caradoc.them.org> from "Daniel Jacobowitz" at Aug 9, 2008 08:14:47 pm

> My understanding is that 1/7, 2/7, 7/7 are approved; 3/7 has a small
> discussion; 4/7 has a big discussion; and no one's looked at 5/7 or
> 6/7 yet.  I'll look at those as soon as I get a chance, so poke me if
> 3/7 and 4/7 are resolved and I haven't done it yet.

I've just tried Pedro's second and third patches for 4/7.  These
apply on top of the corrected first patch.  There are a couple of
typos.  Once these are fixed, the set seems to work (i.e., they
fix the problem of ttrace errors when resuming threads).

There is a typo in the second patch here:

+  info = thread_find_pid (ptid);

This should be find_thread_pid.

The second typo is in the thread patch:

+       printf_unfiltered(_("[%s has been terminated]\n")
+                         target_pid_to_str (ptid));

There's a missing ",'.

Dave
-- 
J. David Anglin                                  dave.anglin@nrc-cnrc.gc.ca
National Research Council of Canada              (613) 990-0752 (FAX: 952-6602)


  reply	other threads:[~2008-08-10  0:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  1:36 [4/7] Adjust the ttrace target (HP-UX) to always register the main thread Pedro Alves
2008-08-08 16:41 ` John David Anglin
2008-08-08 17:24   ` Pedro Alves
2008-08-08 17:49     ` John David Anglin
2008-08-08 18:34     ` ttrace: Protocal error John David Anglin
2008-08-08 20:02       ` Pedro Alves
2008-08-08 20:49         ` John David Anglin
2008-08-10  0:15     ` [4/7] Adjust the ttrace target (HP-UX) to always register the main thread Daniel Jacobowitz
2008-08-10  0:36       ` John David Anglin [this message]
2008-08-10 21:05         ` [4/7] Adjust the ttrace target (HP-UX) to always register the Pedro Alves
2008-08-10 21:16           ` John David Anglin
2008-08-10 21:04       ` John David Anglin
2008-08-14 17:55         ` Daniel Jacobowitz
     [not found] <no.id>
2008-08-10  0:46 ` John David Anglin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080810003551.47C854DCB@hiauly1.hia.nrc.ca \
    --to=dave@hiauly1.hia.nrc.ca \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox