From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7819 invoked by alias); 10 Aug 2008 00:36:28 -0000 Received: (qmail 7811 invoked by uid 22791); 10 Aug 2008 00:36:28 -0000 X-Spam-Check-By: sourceware.org Received: from hiauly1.hia.nrc.ca (HELO hiauly1.hia.nrc.ca) (132.246.100.193) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sun, 10 Aug 2008 00:35:53 +0000 Received: by hiauly1.hia.nrc.ca (Postfix, from userid 1000) id 47C854DCB; Sat, 9 Aug 2008 20:35:50 -0400 (EDT) Subject: Re: [4/7] Adjust the ttrace target (HP-UX) to always register the To: drow@false.org (Daniel Jacobowitz) Date: Sun, 10 Aug 2008 00:36:00 -0000 From: "John David Anglin" Cc: pedro@codesourcery.com, gdb-patches@sourceware.org In-Reply-To: <20080810001447.GB22119@caradoc.them.org> from "Daniel Jacobowitz" at Aug 9, 2008 08:14:47 pm X-Mailer: ELM [version 2.4 PL25] MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Message-Id: <20080810003551.47C854DCB@hiauly1.hia.nrc.ca> Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-08/txt/msg00268.txt.bz2 > My understanding is that 1/7, 2/7, 7/7 are approved; 3/7 has a small > discussion; 4/7 has a big discussion; and no one's looked at 5/7 or > 6/7 yet. I'll look at those as soon as I get a chance, so poke me if > 3/7 and 4/7 are resolved and I haven't done it yet. I've just tried Pedro's second and third patches for 4/7. These apply on top of the corrected first patch. There are a couple of typos. Once these are fixed, the set seems to work (i.e., they fix the problem of ttrace errors when resuming threads). There is a typo in the second patch here: + info = thread_find_pid (ptid); This should be find_thread_pid. The second typo is in the thread patch: + printf_unfiltered(_("[%s has been terminated]\n") + target_pid_to_str (ptid)); There's a missing ",'. Dave -- J. David Anglin dave.anglin@nrc-cnrc.gc.ca National Research Council of Canada (613) 990-0752 (FAX: 952-6602)