From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: go32-nat, always a thread
Date: Sat, 09 Aug 2008 19:31:00 -0000 [thread overview]
Message-ID: <20080809193025.GA7871@caradoc.them.org> (raw)
In-Reply-To: <200808091916.m79JG9TD003200@brahms.sibelius.xs4all.nl>
On Sat, Aug 09, 2008 at 09:16:09PM +0200, Mark Kettenis wrote:
> Instead of
>
> struct foo {
> char c __attribute__((packed));
> int d __attribute__((packed));
> };
>
> you can (should?) write
>
> struct foo {
> char c;
> int d;
> } __attribute__((packed));
Indeed, should (even must). I believe old versions of GCC silently
ignored the packed attribute on fields, but I'm not 100% certain of
that - I must be mistaken if the construct in go32-nat.c previously
worked.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-08-09 19:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 3:39 Pedro Alves
2008-08-08 3:41 ` Pedro Alves
2008-08-08 8:01 ` Eli Zaretskii
2008-08-08 12:43 ` Daniel Jacobowitz
2008-08-08 12:47 ` Eli Zaretskii
2008-08-08 12:55 ` Daniel Jacobowitz
2008-08-09 17:54 ` Pedro Alves
2008-08-09 18:06 ` Tom Tromey
2008-08-09 18:15 ` Pedro Alves
2008-08-09 18:22 ` Daniel Jacobowitz
2008-08-09 18:55 ` Eli Zaretskii
2008-08-09 19:18 ` Mark Kettenis
2008-08-09 19:31 ` Daniel Jacobowitz [this message]
2008-08-09 21:32 ` Eli Zaretskii
2008-08-09 21:33 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080809193025.GA7871@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox