From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-57833-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 29318 invoked by alias); 9 Aug 2008 19:31:13 -0000
Received: (qmail 29245 invoked by uid 22791); 9 Aug 2008 19:31:08 -0000
X-Spam-Check-By: sourceware.org
Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 09 Aug 2008 19:30:28 +0000
Received: from nan.false.org (localhost [127.0.0.1]) 	by nan.false.org (Postfix) with ESMTP id 75CAA98420 	for <gdb-patches@sourceware.org>; Sat,  9 Aug 2008 19:30:26 +0000 (GMT)
Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) 	by nan.false.org (Postfix) with ESMTP id 4769C9813A 	for <gdb-patches@sourceware.org>; Sat,  9 Aug 2008 19:30:26 +0000 (GMT)
Received: from drow by caradoc.them.org with local (Exim 4.69) 	(envelope-from <drow@caradoc.them.org>) 	id 1KRu8v-00023V-4p 	for gdb-patches@sourceware.org; Sat, 09 Aug 2008 15:30:25 -0400
Date: Sat, 09 Aug 2008 19:31:00 -0000
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sourceware.org
Subject: Re: go32-nat, always a thread
Message-ID: <20080809193025.GA7871@caradoc.them.org>
Mail-Followup-To: gdb-patches@sourceware.org
References: <200808080439.17254.pedro@codesourcery.com> <u3algj5qo.fsf@gnu.org> <200808091853.44771.pedro@codesourcery.com> <ud4kihvdv.fsf@gnu.org> <200808091916.m79JG9TD003200@brahms.sibelius.xs4all.nl>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200808091916.m79JG9TD003200@brahms.sibelius.xs4all.nl>
User-Agent: Mutt/1.5.17 (2008-05-11)
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-08/txt/msg00256.txt.bz2

On Sat, Aug 09, 2008 at 09:16:09PM +0200, Mark Kettenis wrote:
> Instead of
> 
> struct foo {
>   char c __attribute__((packed));
>   int d __attribute__((packed));
> };
> 
> you can (should?) write
> 
> struct foo {
>   char c;
>   int d;
> } __attribute__((packed));

Indeed, should (even must).  I believe old versions of GCC silently
ignored the packed attribute on fields, but I'm not 100% certain of
that - I must be mistaken if the construct in go32-nat.c previously
worked.

-- 
Daniel Jacobowitz
CodeSourcery