From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Mark Kettenis <mark.kettenis@xs4all.nl>, gdb-patches@sourceware.org
Subject: Re: [3/7] Adjust the bsd-uthread target
Date: Sat, 09 Aug 2008 01:32:00 -0000 [thread overview]
Message-ID: <20080809013130.GA28372@caradoc.them.org> (raw)
In-Reply-To: <200808082341.23994.pedro@codesourcery.com>
On Fri, Aug 08, 2008 at 11:41:23PM +0100, Pedro Alves wrote:
> The "exited" state is what you get *after* you delete_thread the current
> thread (inferior_ptid). We don't delete the thread from the thread list
> in that case, but instead tag it as "exited". It means the thread list
> is still holding reference to a thread that has already exited.
> If you're seeing an event with a ptid equal to an "exited" thread,
> this is the OS reusing the ptid, but, it's a new thread, which
> should get a new gdb thread id, so things like thread
> specific breakpoints don't think this was the same thread, both the
> CLI user or MI see a "new thread event", etc. add_thread handles
> that case internally. This means it is now safe to delete_thread
> (inferior_ptid), regarding context-switching, and infrun state. It
> wasn't a couple of weeks ago.
How many of the call sites for in_thread_list want to see exited
threads? Maybe there should be another predicate (I'd suggest
thread_alive except target_thread_alive would confuse things...)
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-08-09 1:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 1:36 Pedro Alves
2008-08-08 21:57 ` Mark Kettenis
2008-08-08 22:42 ` Pedro Alves
2008-08-09 1:32 ` Daniel Jacobowitz [this message]
2008-08-11 13:33 ` Pedro Alves
2008-08-14 17:53 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080809013130.GA28372@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=mark.kettenis@xs4all.nl \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox