Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: pedro@codesourcery.com
Cc: gdb-patches@sourceware.org
Subject: Re: [3/7] Adjust the bsd-uthread target
Date: Fri, 08 Aug 2008 21:57:00 -0000	[thread overview]
Message-ID: <200808082151.m78LpP2T028239@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <200808080236.04076.pedro@codesourcery.com> (message from Pedro 	Alves on Fri, 8 Aug 2008 02:36:03 +0100)

> From: Pedro Alves <pedro@codesourcery.com>
> Date: Fri, 8 Aug 2008 02:36:03 +0100
> 
> This patch adjusts the bsd-uthread target to use thread_change_ptid,
> and to never let the core see an event happen in a thread not in
> the thread table.
> 
> Tested on i386-unknown-freebsd6.0 with a little hack in the
> testsuite to link the gdb.thread tests against -lc_r instead
> of -lpthread, and on i386-unknown-openbsd4.3, where no hack is
> needed.
> 
> This patch depends on patch 1 and 2.
> 
> OK?
> 
> Index: src/gdb/bsd-uthread.c
> ===================================================================
> --- src.orig/gdb/bsd-uthread.c	2008-07-29 12:06:38.000000000 +0100
> +++ src/gdb/bsd-uthread.c	2008-07-29 12:17:34.000000000 +0100
> @@ -413,7 +415,7 @@ bsd_uthread_find_new_threads (void)
>      {
>        ptid_t ptid = ptid_build (pid, 0, addr);
>  
> -      if (!in_thread_list (ptid))
> +      if (!in_thread_list (ptid) || is_exited (ptid))
>	    add_thread (ptid);

This doesn't make sense to me.  You're adding a threadhere that's no
longer there?


  reply	other threads:[~2008-08-08 21:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  1:36 Pedro Alves
2008-08-08 21:57 ` Mark Kettenis [this message]
2008-08-08 22:42   ` Pedro Alves
2008-08-09  1:32     ` Daniel Jacobowitz
2008-08-11 13:33       ` Pedro Alves
2008-08-14 17:53         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808082151.m78LpP2T028239@brahms.sibelius.xs4all.nl \
    --to=mark.kettenis@xs4all.nl \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox