Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: drow@false.org (Daniel Jacobowitz)
Cc: gdb-patches@sourceware.org
Subject: Re: [gdbserver] Problems trying to resume dead threads
Date: Mon, 04 Aug 2008 19:46:00 -0000	[thread overview]
Message-ID: <200808041945.m74Jjkcf028811@d12av02.megacenter.de.ibm.com> (raw)
In-Reply-To: <20080804182930.GA23825@caradoc.them.org> from "Daniel Jacobowitz" at Aug 04, 2008 02:29:30 PM

Daniel Jacobowitz wrote:
> On Mon, Aug 04, 2008 at 08:23:14PM +0200, Ulrich Weigand wrote:
> > Hmm, still fails with my Cell test case like this:
> > writing register 25: No such process
> > ptrace(regsets_fetch_inferior_registers) PID=14241: No such process
> > reading register 0: No such process
> 
> :-( It must depend on where you are in gdbserver when the process is
> killed.  I hadn't thought about that.
> 
> Perhaps we should downgrade all these errors to warnings for errno ==
> ESRCH?

It seems the "read" errors are just artifacts: because of the first
error (on writing the register), the "error" call performs a longjmp
to the toplevel, which leaves things in a somewhat strange state.

The only "real" errors I see (in addition to the one in
linux_resume_one_process) are the cases in regsets_store_inferior_registers
(which is already a warning) and usr_store_inferior_registers (which
is not).

In any case, I don't think these should be even warnings for ESRCH:
showing a warning in a situation that is completely normal and in
fact handled correctly would just confuse users IMO.

I'd propose to just silently ignore ESRCH errors while writing registers
(in addition to your patch).  What do you think?

Bye,
Ulrich

-- 
  Dr. Ulrich Weigand
  GNU Toolchain for Linux on System z and Cell BE
  Ulrich.Weigand@de.ibm.com


  reply	other threads:[~2008-08-04 19:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-19 17:17 Ulrich Weigand
2008-08-04 13:40 ` Daniel Jacobowitz
2008-08-04 18:25   ` Ulrich Weigand
2008-08-04 18:30     ` Daniel Jacobowitz
2008-08-04 19:46       ` Ulrich Weigand [this message]
2008-08-04 19:55         ` Daniel Jacobowitz
2008-08-05 21:06           ` Ulrich Weigand
2008-08-05 21:59             ` Daniel Jacobowitz
2008-08-05 22:15               ` Ulrich Weigand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808041945.m74Jjkcf028811@d12av02.megacenter.de.ibm.com \
    --to=uweigand@de.ibm.com \
    --cc=drow@false.org \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox