Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Fix for failing gdb.base/auxv.exp on Linux
@ 2008-07-17 20:07 Paul Pluzhnikov
  2008-07-17 20:53 ` Daniel Jacobowitz
  0 siblings, 1 reply; 2+ messages in thread
From: Paul Pluzhnikov @ 2008-07-17 20:07 UTC (permalink / raw)
  To: gdb-patches

Greetings,

gdb.base/auxv.exp is failing for me on Linux, because 'info auxv'
from live process prints several trailing AT_NULL entries:

(gdb) inf auxv
32   AT_SYSINFO           Special system info/entry points 0xffffe400
33   AT_SYSINFO_EHDR      System-supplied DSO's ELF header 0xffffe000
...
15   AT_PLATFORM          String identifying platform    0xffffda3b "i686"
0    AT_NULL              End of vector                  0x0
0    AT_NULL              End of vector                  0x0
0    AT_NULL              End of vector                  0x0

Attached patch terminates the list at first AT_NULL, and makes the
test succeed.

Ok to commit?

--
Paul Pluzhnikov


2008-07-17  Paul Pluzhnikov  <ppluzhnikov@google.com>

	* auxv.c (fprint_target_auxv): Stop at AT_NULL.


Index: auxv.c
===================================================================
RCS file: /cvs/src/src/gdb/auxv.c,v
retrieving revision 1.11
diff -u -p -u -r1.11 auxv.c
--- auxv.c	4 May 2008 09:28:27 -0000	1.11
+++ auxv.c	17 Jul 2008 18:57:18 -0000
@@ -246,6 +246,8 @@ fprint_target_auxv (struct ui_file *file
 	  break;
 	}
       ++ents;
+      if (type == AT_NULL)
+	break;
     }
 
   xfree (data);


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [RFA] Fix for failing gdb.base/auxv.exp on Linux
  2008-07-17 20:07 [RFA] Fix for failing gdb.base/auxv.exp on Linux Paul Pluzhnikov
@ 2008-07-17 20:53 ` Daniel Jacobowitz
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2008-07-17 20:53 UTC (permalink / raw)
  To: Paul Pluzhnikov; +Cc: gdb-patches

On Thu, Jul 17, 2008 at 01:06:30PM -0700, Paul Pluzhnikov wrote:
> Ok to commit?

Ok.

-- 
Daniel Jacobowitz
CodeSourcery


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-17 20:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-17 20:07 [RFA] Fix for failing gdb.base/auxv.exp on Linux Paul Pluzhnikov
2008-07-17 20:53 ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox