From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
Cc: gdb-patches@sourceware.org
Subject: Re: [commit] Rename frame_pc_unwind and frame_unwind_id
Date: Tue, 15 Jul 2008 19:09:00 -0000 [thread overview]
Message-ID: <200807151908.m6FJ8YK3001326@brahms.sibelius.xs4all.nl> (raw)
In-Reply-To: <20080715190125.GC32644@caradoc.them.org> (message from Daniel Jacobowitz on Tue, 15 Jul 2008 15:01:25 -0400)
> Date: Tue, 15 Jul 2008 15:01:25 -0400
> From: Daniel Jacobowitz <drow@false.org>
>
> This patch is the first non-trivial change in inlining support, and
> readily separable.
Non-trivial...
> The users of frame_unwind_id and frame_pc_unwind are all either
> inferior control, trying to find the caller / return address of a new
> function, or trampoline handling. I audited all of the uses, and the
> right behavior in every one of them is to ignore any inlined functions
> at the current location. A future patch, the one adding inlined
> frames, will make the corresponding change to frame_unwind_caller_id
> and frame_unwind_caller_pc. For now, I've just renamed them to
> indicate the correct expectations.
...so cann't we discuss this first please?
next prev parent reply other threads:[~2008-07-15 19:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 19:01 Daniel Jacobowitz
2008-07-15 19:09 ` Mark Kettenis [this message]
2008-07-15 19:22 ` Daniel Jacobowitz
2008-07-15 22:41 ` Mark Kettenis
2008-07-15 23:29 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807151908.m6FJ8YK3001326@brahms.sibelius.xs4all.nl \
--to=mark.kettenis@xs4all.nl \
--cc=drow@false.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox