From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-57310-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 20732 invoked by alias); 15 Jul 2008 19:09:03 -0000
Received: (qmail 20723 invoked by uid 22791); 15 Jul 2008 19:09:03 -0000
X-Spam-Check-By: sourceware.org
Received: from sibelius.xs4all.nl (HELO sibelius.xs4all.nl) (82.92.89.47)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 15 Jul 2008 19:08:42 +0000
Received: from brahms.sibelius.xs4all.nl (kettenis@localhost.sibelius.xs4all.nl [127.0.0.1]) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3) with ESMTP id m6FJ8YPo014884; 	Tue, 15 Jul 2008 21:08:34 +0200 (CEST)
Received: (from kettenis@localhost) 	by brahms.sibelius.xs4all.nl (8.14.3/8.14.3/Submit) id m6FJ8YK3001326; 	Tue, 15 Jul 2008 21:08:34 +0200 (CEST)
Date: Tue, 15 Jul 2008 19:09:00 -0000
Message-Id: <200807151908.m6FJ8YK3001326@brahms.sibelius.xs4all.nl>
From: Mark Kettenis <mark.kettenis@xs4all.nl>
To: drow@false.org
CC: gdb-patches@sourceware.org
In-reply-to: <20080715190125.GC32644@caradoc.them.org> (message from Daniel 	Jacobowitz on Tue, 15 Jul 2008 15:01:25 -0400)
Subject: Re: [commit] Rename frame_pc_unwind and frame_unwind_id
References:  <20080715190125.GC32644@caradoc.them.org>
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2008-07/txt/msg00322.txt.bz2

> Date: Tue, 15 Jul 2008 15:01:25 -0400
> From: Daniel Jacobowitz <drow@false.org>
> 
> This patch is the first non-trivial change in inlining support, and
> readily separable.

Non-trivial...

> The users of frame_unwind_id and frame_pc_unwind are all either
> inferior control, trying to find the caller / return address of a new
> function, or trampoline handling.  I audited all of the uses, and the
> right behavior in every one of them is to ignore any inlined functions
> at the current location.  A future patch, the one adding inlined
> frames, will make the corresponding change to frame_unwind_caller_id
> and frame_unwind_caller_pc.  For now, I've just renamed them to
> indicate the correct expectations.

...so cann't we discuss this first please?