From: Daniel Jacobowitz <drow@false.org>
To: Pedro Alves <pedro@codesourcery.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [continuation args 2/2] Make continuation args not leak
Date: Sat, 12 Jul 2008 18:55:00 -0000 [thread overview]
Message-ID: <20080712185448.GB1171@caradoc.them.org> (raw)
In-Reply-To: <200807112138.55781.pedro@codesourcery.com>
On Fri, Jul 11, 2008 at 09:38:55PM +0100, Pedro Alves wrote:
> + struct cleanup **as_cleanup_p = (struct cleanup **) &cmd_continuation;
> + make_cleanup_ftype *continuation_hook_ftype = continuation_hook;
ftype stands for function type, and our convention is to use it for
types only. So please don't use it in the name of a variable.
continuation_fn?
> +static void
> +finish_command_continuation_free_arg (void *arg)
> +{
> + /* NOTE: See finish_command_continuation. This would go away, if
> + this suppressing is made a thread property. */
> + suppress_stop_observer = 0;
> +}
Doesn't it still need to call xfree?
Otherwise OK.
--
Daniel Jacobowitz
CodeSourcery
next prev parent reply other threads:[~2008-07-12 18:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 20:39 Pedro Alves
2008-07-12 18:55 ` Daniel Jacobowitz [this message]
2008-07-12 19:28 ` Pedro Alves
2008-07-12 20:24 ` Ulrich Weigand
2008-07-12 22:53 ` Pedro Alves
2008-07-13 4:28 ` Daniel Jacobowitz
2008-07-13 11:30 ` Pedro Alves
2008-07-15 18:44 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080712185448.GB1171@caradoc.them.org \
--to=drow@false.org \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox