From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27989 invoked by alias); 12 Jul 2008 18:55:10 -0000 Received: (qmail 27981 invoked by uid 22791); 12 Jul 2008 18:55:10 -0000 X-Spam-Check-By: sourceware.org Received: from NaN.false.org (HELO nan.false.org) (208.75.86.248) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 12 Jul 2008 18:54:51 +0000 Received: from nan.false.org (localhost [127.0.0.1]) by nan.false.org (Postfix) with ESMTP id 02FB398415; Sat, 12 Jul 2008 18:54:49 +0000 (GMT) Received: from caradoc.them.org (22.svnf5.xdsl.nauticom.net [209.195.183.55]) by nan.false.org (Postfix) with ESMTP id CFAA79809E; Sat, 12 Jul 2008 18:54:48 +0000 (GMT) Received: from drow by caradoc.them.org with local (Exim 4.69) (envelope-from ) id 1KHkF6-0000SV-2e; Sat, 12 Jul 2008 14:54:48 -0400 Date: Sat, 12 Jul 2008 18:55:00 -0000 From: Daniel Jacobowitz To: Pedro Alves Cc: gdb-patches@sourceware.org Subject: Re: [continuation args 2/2] Make continuation args not leak Message-ID: <20080712185448.GB1171@caradoc.them.org> Mail-Followup-To: Pedro Alves , gdb-patches@sourceware.org References: <200807112138.55781.pedro@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807112138.55781.pedro@codesourcery.com> User-Agent: Mutt/1.5.17 (2008-05-11) X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-07/txt/msg00234.txt.bz2 On Fri, Jul 11, 2008 at 09:38:55PM +0100, Pedro Alves wrote: > + struct cleanup **as_cleanup_p = (struct cleanup **) &cmd_continuation; > + make_cleanup_ftype *continuation_hook_ftype = continuation_hook; ftype stands for function type, and our convention is to use it for types only. So please don't use it in the name of a variable. continuation_fn? > +static void > +finish_command_continuation_free_arg (void *arg) > +{ > + /* NOTE: See finish_command_continuation. This would go away, if > + this suppressing is made a thread property. */ > + suppress_stop_observer = 0; > +} Doesn't it still need to call xfree? Otherwise OK. -- Daniel Jacobowitz CodeSourcery